Re: [Xen-devel] [PATCH v2 14/18] libxl: introduce libxl_get_memory_static_max

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Aug 28, 2014 at 07:16:03PM +0100, Ian Campbell wrote:
> On Thu, 2014-08-28 at 12:31 +0100, Wei Liu wrote:
> 
> > > > @@ -884,6 +891,7 @@ int libxl_domain_core_dump(libxl_ctx *ctx, uint32_t 
> > > > domid,
> > > >  int libxl_domain_setmaxmem(libxl_ctx *ctx, uint32_t domid, uint32_t 
> > > > target_memkb);
> > > >  int libxl_set_memory_target(libxl_ctx *ctx, uint32_t domid, int32_t 
> > > > target_memkb, int relative, int enforce);
> > > >  int libxl_get_memory_target(libxl_ctx *ctx, uint32_t domid, uint32_t 
> > > > *out_target);
> > > > +int libxl_get_memory_static_max(libxl_ctx *ctx, uint32_t domid, 
> > > > uint32_t *out_static_max);
> > > 
> > > Do you need this to be public, or did you just do it for consistency?
> > > 
> > 
> > I did it for consistency, in case it's useful to library users. If you
> > would rather not expose this I can make it internal.
> 
> In general I'm wary of adding to the API "just because". Refactoring an
> internal function to be externally available when a requirement arises
> is pretty easy, whereas changing an already public function because the
> eventual requirement turned out not to be what we expected is harder.
> 

OK, let's make it an internal function.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel