Re: [Xen-devel] [RFC PATCH] cpufreq: make cpufreq driver more generalizable

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.08.14 at 15:04, <oleksandr.dmytryshyn@xxxxxxxxxxxxxxx> wrote:
> First implementation of the cpufreq infrastructure
> has been written with x86 in mind. This patch makes
> possible the cpufreq driver be working on both x86
> and arm architecture.
> 
> Signed-off-by: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@xxxxxxxxxxxxxxx>
> ---
>  xen/arch/arm/cpufreq/cpufreq_ops.c           | 248 ++++++++++++++++
>  xen/arch/x86/acpi/cpu_idle.c                 |   2 +-
>  xen/arch/x86/acpi/cpufreq/Makefile           |   1 +
>  xen/arch/x86/acpi/cpufreq/cpufreq.c          |   2 +-
>  xen/arch/x86/acpi/cpufreq/cpufreq_ops.c      | 424 
> +++++++++++++++++++++++++++
>  xen/arch/x86/acpi/cpufreq/powernow.c         |   2 +-
>  xen/arch/x86/acpi/power.c                    |   2 +-
>  xen/arch/x86/cpu/mwait-idle.c                |   2 +-
>  xen/drivers/acpi/pmstat.c                    |   2 +-
>  xen/drivers/cpufreq/cpufreq.c                | 421 +-------------------------
>  xen/drivers/cpufreq/cpufreq_misc_governors.c |   2 +-
>  xen/drivers/cpufreq/cpufreq_ondemand.c       |   9 +-
>  xen/drivers/cpufreq/utility.c                |  21 +-
>  xen/include/acpi/cpufreq/cpufreq.h           | 258 ----------------
>  xen/include/acpi/cpufreq/processor_perf.h    |   3 -
>  xen/include/xen/cpufreq.h                    | 285 ++++++++++++++++++
>  16 files changed, 1000 insertions(+), 684 deletions(-)

This certainly looks like a useful thing to do, but can this not be
broken up at least a little, so reviewing becomes a reasonable job?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel