Re: [Xen-devel] [PATCH v5] xen: arm: introduce uImage probe function for Dom0

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Oleksandr,

On 28/08/14 06:54, Oleksandr Dmytryshyn wrote:
>   #ifdef CONFIG_ARM_64
>   /*
>    * Check if the image is a 64-bit Image.
> @@ -398,6 +467,8 @@ int kernel_probe(struct kernel_info *info)
>       rc = kernel_zimage64_probe(info, start, size);
>       if (rc < 0)
>   #endif
> +        rc = kernel_uimage_probe(info, start, size);
> +    if(rc < 0 )
NIT: the coding style is:

if ( rc < 0 )

It looks like the other if in this function don't respect the coding 
style. I wouldn't resend a new version of this patch this small NIT. 
Maybe Ian can fix it when it will be applied?

Anyway:

Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel