Re: [Xen-devel] [PATCH RFC v2 08/12] xen/arm: Add mem_event domctl and mem_access memop.

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Fri, Aug 29, 2014 at 10:57 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:

Hello Tamas,

On 27/08/14 10:06, Tamas K Lengyel wrote:

+    case XEN_DOMCTL_mem_event_op:
+        ret = mem_event_domctl(d, &domctl->u.mem_event_op,
+                               guest_handle_cast(u_domctl, void));
+        copyback = 1;
+    break;

The code for this domctl is exactly the same on x86. Therefore, I would move it in common/domctl.c.

Of course, you will have to protected with an #ifdef HAVE_MEMACCESS or whatever define used to know when mem event is supported for the platform.

+
+    case XENMEM_access_op:
+        rc = mem_access_memop(op, guest_handle_cast(arg, xen_mem_access_op_t));
+        break;

Same remark here.

--
Julien Grall

That would make sense, thanks!

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel