Re: [Xen-devel] [PATCH v3 1/2] x86: add p2m_mmio_write_dm

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.09.14 at 11:54, <Paul.Durrant@xxxxxxxxxx> wrote:
>> From: Wei Ye [mailto:wei.ye@xxxxxxxxx]
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -2739,7 +2739,8 @@ int hvm_hap_nested_page_fault(paddr_t gpa,
>>       * to the mmio handler.
>>       */
>>      if ( (p2mt == p2m_mmio_dm) ||
>> -         (access_w && (p2mt == p2m_ram_ro)) )
>> +         (access_w && ((p2mt == p2m_ram_ro) ||
>> +         (p2mt == p2m_mmio_write_dm))) )
> 
> Personally I would have put the two p2m_mmio checks next to each other, but 
> it doesn't really matter.

At the very least the indentation would need adjustment if the
ordering is to be kept as it is now.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel