[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xc_cpuid_x86.c: No need to mask NX twice

>>> On 05.09.14 at 17:45, <alfred.z.song@xxxxxxxxx> wrote:
> Hi, Jan
> I am sorry for making you confused.
> What I mean is there seems to be some redundant work. For example, to leaf
> 0x80000001, the generic work (masking NX and PSE36) has been overwritten by
> the the vendor's functions (amd_xc_cpuid_policy and intel_xc_cpuid_policy)
> , why couldn't we just drop them and leave the work to the vendor?  Of
> cause, another way is just like you said, keeping the generic ones, and
> changing the logic in the vendor-based implementation.
> What I want to do is to simplify this if possible. :)

Right, yet conceptually anything that is defined by the architecture
would better be done in the generic routine. Anything that is truly
vendor specific should be done in the vendor ones. And the
dependency of NX on PAE is (nowadays) an architectural one.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.