Re: [Xen-devel] [PATCH] numa.c: use spaces instead of tabs

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.09.14 at 19:28, <dslutz@xxxxxxxxxxx> wrote:
> Using this on xen/arch/x86/numa.c (and asking git to ignore white space
> changes) gives me:
> 
> dcs-xen-54:~/xen>git diff -w
> diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
> index 628a40a..35ce32c 100644
> --- a/xen/arch/x86/numa.c
> +++ b/xen/arch/x86/numa.c
> @@ -35,13 +35,15 @@ static typeof(*memnodemap) _memnodemap[64];
>   unsigned long memnodemapsize;
>   u8 *memnodemap;
> 
> -unsigned char cpu_to_node[NR_CPUS] __read_mostly = {
> +unsigned char cpu_to_node[NR_CPUS] __read_mostly =
> +{
>       [0 ... NR_CPUS - 1] = NUMA_NO_NODE
>   };
>   /*
>    * Keep BIOS's CPU2node information, should not be used for memory allocaion
>    */
> -unsigned char apicid_to_node[MAX_LOCAL_APIC] __cpuinitdata = {
> +unsigned char apicid_to_node[MAX_LOCAL_APIC] __cpuinitdata =
> +{
>       [0 ... MAX_LOCAL_APIC - 1] = NUMA_NO_NODE
>   };
>   cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly;
> @@ -413,7 +415,8 @@ static void dump_numa(unsigned char key)
>       rcu_read_unlock(&domlist_read_lock);
>   }
> 
> -static struct keyhandler dump_numa_keyhandler = {
> +static struct keyhandler dump_numa_keyhandler =
> +{
>       .diagnostic = 1,
>       .u.fn = dump_numa,
>       .desc = "dump numa info"

Except that I think on initializers we don't strictly require the { to
be on a separate line, albeit I admit that one can conclude either
way from ./CODING_STYLE.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel