[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] IPI sending difference between x86 and ARM

>>> On 10.09.14 at 12:19, <Ian.Campbell@xxxxxxxxxxxxx> wrote:
> On Wed, 2014-09-10 at 11:10 +0100, Jan Beulich wrote:
>> >>> On 10.09.14 at 12:01, <Ian.Campbell@xxxxxxxxxxxxx> wrote:
>> > Anyway, if smp_send_event_check_mask is supposed to exclude the calling
>> > CPU then we should fix that on ARM in the name of consistency/sanity. In
>> > the event it causes other issues then we should fix those as they arise.
>> Actually I was instead considering to filter the local CPU in
>> cpumask_raise_softirq(), just like cpu_raise_softirq() does. That
>> would make changes to smp_send_event_check_mask()
>> unnecessary.
> Sure, that would be fine and good too.
> But independent of that I think smp_send_event_check_mask() should
> behave the same on x86 as ARM wrt including the current CPU.

But the dropping of the local CPU doesn't happen in
smp_send_event_check_mask() on x86 - it's further down the
call chain where this gets done. And by fixing the caller we make
it so that the specific arch's behavior doesn't matter anymore.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.