Re: [Xen-devel] [PATCH 21/29] tools/libxl: Allow adding larger amounts of prefixdata to datacopier

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-09-11 at 13:17 +0100, Ross Lagerwall wrote:
> On 09/11/2014 01:01 PM, Ian Campbell wrote:
> > On Wed, 2014-09-10 at 18:10 +0100, Andrew Cooper wrote:
> >> From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> >>
> >> Previously, adding more than 1000 bytes of data would cause a segfault.
> >
> > Segfault is a symptom, not a cause, why does it happen?
> 
> struct libxl__datacopier_buf contains a fixed size 1000 byte statically 
> allocated buffer so adding > 1000 bytes of data would cause it to 
> overrun the buffer and overwrite other memory.

Yes, this should be the main point of the commit log though.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel