Re: [Xen-devel] [PATCH 26/29] tools/libxl: Implement libxl__domain_restore() for v2 streams

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 11/09/14 13:35, Ian Campbell wrote:
> On Wed, 2014-09-10 at 18:11 +0100, Andrew Cooper wrote:
>> TODO:
>>  * Integrate with the json series
> How much will that invalidate the patch wrt my reviewing it now?

Hopefully not much, but it does complicate the use of d_config.  Perhaps
we can start with d_config being unconditional, and the json series can
make it optional in the case a blob can be found in the stream.

>
>> Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>>  tools/libxl/libxl_create.c   |  310 
>> ++++++++++++++++++++++++++++++++++++++++--
> Would it be possible to move most/all of the restore code into a new
> file? If it doesn't involve exposing too many currently static bits then
> that might be a good thing to do.
>
>
>

Most code should be self contained.  libxl_domain_{save,restore}.c sound
like a good idea.

~Andrew


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel