[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [v6][PATCH 2/7] tools/libxc: introduce hypercall for xc_reserved_device_memory_map

On 11/09/14 16:21, Jan Beulich wrote:
>>>> On 10.09.14 at 07:49, <tiejun.chen@xxxxxxxxx> wrote:
>> +    if ( errno == ENOBUFS )
>> +        *max_entries = memmap.nr_entries;
>> +
>> +    return rc ? -errno : memmap.nr_entries;
>> +}
> Isn't libxc generally aiming at using POSIX style return values, i.e. -1
> one error with errno indicating the details? Furthermore you're even
> inconsistent with yourself, as you return -1 in an earlier error path.

Furthermore, this in now the 3rd time I have commented on this problem
specifically, across different versions of this series.

Please address all outstanding comments before reposting.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.