[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 09/29] [HACK] tools/libxc: save/restore v2 framework

On Sep 11, 2014 4:08 AM, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx> wrote:
> On 11/09/14 12:01, Ian Campbell wrote:
> > On Thu, 2014-09-11 at 11:37 +0100, Andrew Cooper wrote:
> >> On 11/09/14 11:34, Ian Campbell wrote:
> >>> On Wed, 2014-09-10 at 18:10 +0100, Andrew Cooper wrote:
> >>>> For testing purposes, the environmental variable "XG_MIGRATION_V2" allows the
> >>>> two save/restore codepaths to coexist, and have a runtime switch.
> >>>>
> >>>> It is indended that once this series is less RFC, the v2 framework will
> >>>> completely replace v1.
> >>> I think we are now at the point where this hack needs to be dropped from
> >>> the series.
> >> One problem is remus. ÂMy plan when dropping this patch was to drop all
> >> of xc_domain_{save/restore}.c as well, but without remus migration-v2
> >> support available, this will break existing set-ups.
> > Hrm, how is that going wrt 4.5 freeze?
> I havenât heard seen anything since v5 of this series (for which I did
> some quick bugfixes and released v6).

FYI, thats not entirely true. Yang did post a set of RFC patches for remusÂ
support in migration v2, based on your V6 series (back in July)

It would actually be helpful if you could cc me on the patches relevant to Remus,
or if there is anything specific to Remus that needs to be done. There are 100s of
posts on Xen devel every day and its hard to keep track of everything posted toÂ
Xen devel.

And I looking at your patch sets in

I see that there is no support for Remus currently. Nor can I differentiate which parts of the
code fix to these "quick bug fixes" that you mentioned above. From the discussion over the remus rfc
patches, I only recall a bug related to vcpu context caching. But I cannot delineate that specific part from
the patches in the repo. So, if these bug fixes you are referring to are something else, please explain.

> I don't know, which probably means not good.

> >
> >> One option might be to have legacy and v2 sitting properly side-by-side
> >> in libxc for the transition period.
> > How long do you mean? Until 4.6?

fwiw, I don't plan to work on remus migration v2 support until the remus netbuffer patches get in.
I have been at this for almost two release cycles. Its frustrating to iterate on feedbacks for patch 4/11Â
of a series for two months and then get a bunch of first-pass review for patch 6/10 at the eleventh hour
before a feature freeze, while the rest of the series has still not been reviewed at all for the past 3 months.

> Ideally, very early in the 4.6 dev period.
> ~Andrew
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.