[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/4] drivers/xen/xenbus/xenbus_client.c: Remove redundancy asignment to 'addr'

To: Chen Gang <gang.chen.5i5j@xxxxxxxxx>, <konrad.wilk@xxxxxxxxxx>, <boris.ostrovsky@xxxxxxxxxx>, David Vrabel <david.vrabel@xxxxxxxxxx>, <stefano.stabellini@xxxxxxxxxxxxx>, <mukesh.rathor@xxxxxxxxxx>
From: David Vrabel <david.vrabel@xxxxxxxxxx>
Date: Mon, 15 Sep 2014 16:41:15 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
Delivery-date: Mon, 15 Sep 2014 15:41:29 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 14/09/14 11:49, Chen Gang wrote:
> When failure occurs, 'node' is already set to NULL, and it is enough
> for next checking (which will return in time), so need not set 'addr'.

I'm not going to apply this one.  The redundant assignment is harmless
and improve clarity slightly, IMO.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

Follow-Ups:
- Re: [Xen-devel] [PATCH 1/4] drivers/xen/xenbus/xenbus_client.c: Remove redundancy asignment to 'addr'
  - From: Chen Gang

References:
- [Xen-devel] [PATCH 0/4] drivers/xen/xenbus/xenbus_client.c: Several improvements for it
  - From: Chen Gang
- [Xen-devel] [PATCH 1/4] drivers/xen/xenbus/xenbus_client.c: Remove redundancy asignment to 'addr'
  - From: Chen Gang

Prev by Date: [Xen-devel] [linux-3.10 test] 30276: regressions - FAIL
Next by Date: Re: [Xen-devel] [PATCH 5/5] make: Make "src-tarball" target actually make a source tarball
Previous by thread: Re: [Xen-devel] [PATCH 1/4] drivers/xen/xenbus/xenbus_client.c: Remove redundancy asignment to 'addr'
Next by thread: Re: [Xen-devel] [PATCH 1/4] drivers/xen/xenbus/xenbus_client.c: Remove redundancy asignment to 'addr'
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.