Re: [Xen-devel] [PATCH 5/5] make: Make "src-tarball" target actually make a source tarball

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Thu, Jul 17, 2014 at 5:46 PM, George Dunlap
<george.dunlap@xxxxxxxxxxxxx> wrote:
> On 07/16/2014 04:06 PM, Ian Jackson wrote:
>>
>> George Dunlap writes ("[PATCH 5/5] make: Make "src-tarball" target
>> actually make a source tarball"):
>>>
>>> At the moment, making a release tarball is an annoyingly manual
>>> process that involves running "git archive" into a temporary directory.
>>
>> ...
>>>
>>> +src-tarball: subtree-update
>>> +       bash ./tools/misc/mktarball $(XEN_ROOT) $$(git describe)
>>
>> Does this absolutely have to depend on subtree-update ?  Perhaps we
>> need a new "make the subtrees exist" target ?
>
>
> I'll add a "subtree-find" command (perhaps renaming the other to
> "subtree-force-update"; then as per IanC's suggestion, I'll make this depend
> on subtree-force-update unless some sensible parameter is set.

Ian J,

I'm not sure if you remember much about this discussion from two
months ago; I've just realized that this patch series never quite made
it in, and am going back addressing things.

The original patch series will automatically call
"subtree-force-update", which will call force-update on all configured
subtrees (qemu-xen, qemu-trad, seabios, ovmf).

It sounded from your comment above like you'd like to be able to make
a version of src-tarball which will call "*-dir-find" to *instantiate*
the directory if it's not there, but will leave it alone if it is
there.

I started trying to implement a "subtree-find" command which would
call *-dir-find on all the subtrees; but it turns out to be a bit more
complicated because tools/firmware/Makefile doesn't have nice clean
"*-find-dir" targets for ovmf and seabios like qemu does.  Instead, it
has targets which will call git-checkout, and then do some kind of
configuration.  Making it do the configuration in the right place will
probably not be a simple change.

(In fact, technically ovmf-dir-force-update and
seabios-dir-force-update may be broken at the moment, because they
don't do the post-checkout update things.)

Which leaves me three options:
1. Do the work to add "clean" ovmf-find-dir and seabios-find-dir targets
2. Make "subtree-find" just call the current targets, which will stay
on the same
3. Not implement subtree-find at the moment, but just make src-tarball
depend only on subtree-force-update.

#2 I think is a bad idea, because it gives you the impression that
it's being nice and not messing with your config, when in fact it is.

Given that #1 will take some work, and how close we are to the code
freeze, and that it's just an "extra option" over the force-update
default, I propose going with #3.

Does that sound reasonable?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel