[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.5 v6 05/16] tools: Add vmware_port support

On 09/22/14 09:41, Ian Campbell wrote:
On Sat, 2014-09-20 at 14:07 -0400, Don Slutz wrote:
This new libxl_domain_create_info field is used to set
XEN_DOMCTL_CDF_vmware_port for the xc_domain_create() routine.
Does this really need to be a CDF, rather than a domctl/hvm param?

It makes the setting up of v->arch.hvm_vmx.exception_bitmap happen at the right
time.  domctl/hvm param happen later in the start of a domain.

The latter would allow moving to buildinfo.u.hvm, which would be nicer
from the libxl PoV, I think.

I could not find "buildinfo.u.hvm":

dcs-xen-54:~/xen>git grep buildinfo.u.hvm

So unable to comment.

In xen it is is_vmware_port_enabled.

If is_vmware_port_enabled then
   enable a limited support of VMware's hyper-call.

VMware's hyper-call is also known as VMware Backdoor I/O Port.

Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>
Is it useful to be able to configure this independently of the vmware_hw


If yes then I still think you would want to set the default based on
vmware-hw, wouldn't you?

I guess so since this is a BOOLEAN. Currently I do not know of a way to say "set vmware_hw to 7 if vmware_port is true and vmware_hw is not specified". Which would be the inverse. I lean to
not having the default of vmware_port based on vmware_hw.

   -Don Slutz


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.