[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.5 v6 05/16] tools: Add vmware_port support

On Mon, 2014-09-22 at 12:42 -0400, Don Slutz wrote:
> > The latter would allow moving to buildinfo.u.hvm, which would be nicer
> > from the libxl PoV, I think.
> I could not find "buildinfo.u.hvm":
> dcs-xen-54:~/xen>git grep buildinfo.u.hvm
> dcs-xen-54:~/xen>
> So unable to comment.

It's in the idl, next to createinfo.
> > If yes then I still think you would want to set the default based on
> > vmware-hw, wouldn't you?
> I guess so since this is a BOOLEAN.

defbool I hope.

>   Currently I do not know of a way to 
> say "set vmware_hw to 7
> if vmware_port is true and vmware_hw is not specified".

That's an error case, isn't it? Or at least a vmware_port is ignored

What I suggested was "if vmware_hw is non-zero then set vmware_port".

>   Which would be 
> the inverse.  I lean to
> not having the default of vmware_port based on vmware_hw.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.