[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 30/46] Use configure --localstatedir=BASEDIR to set path to /var

On Mon, 2014-09-22 at 15:00 +0200, Olaf Hering wrote:
> This is helpful to test make uninstall with --prefix=/private/dir as
> unprivileged user. No change in behaviour is expected by this change.

It would be worth noting here that this is somewhere where we (already)
conciously decided to deviate from the default autoconf behaviour in
favour of the FHS location for this stuff (which is /var
not /usr/local/var). So this change preserves our chosen default while
now enabling the configure option to work.

> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> ---
>  m4/paths.m4 | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
> diff --git a/m4/paths.m4 b/m4/paths.m4
> index d21850b..deb9196 100644
> --- a/m4/paths.m4
> +++ b/m4/paths.m4
> @@ -2,6 +2,9 @@ AC_DEFUN([AX_XEN_EXPAND_CONFIG], [
>  dnl expand these early so we can use this for substitutions
>  test "x$prefix" = "xNONE" && prefix=$ac_default_prefix
>  test "x$exec_prefix" = "xNONE" && exec_prefix=${prefix}

It might be worth reiterating some of what I said above in a comment
here too.

>  case "$host_os" in
> -*freebsd*) XEN_LOCK_DIR=/var/lib ;;
> -*netbsd*) XEN_LOCK_DIR=/var/lib ;;
> -*) XEN_LOCK_DIR=/var/lock ;;
> +*freebsd*) XEN_LOCK_DIR=$localstatedir/lib ;;
> +*netbsd*) XEN_LOCK_DIR=$localstatedir/lib ;;
> +*) XEN_LOCK_DIR=$localstatedir/lock ;;

I've been continually surprised in this series that autoconf doesn't
just Do The Right Thing on different $host_os's. I thought that was the
point of it.

Oh well, not your fault here (or in the other places).

Apart from the commit message/comment additions the code here looks
correct to me.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.