Re: [Xen-devel] [PATCH 31/46] Add configure --enable-rpath

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-09-22 at 15:00 +0200, Olaf Hering wrote:
> This fixes the tools when xen is configured with --prefix=/odd/path
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> ---
>  Config.mk                      |  3 +++
>  config/Tools.mk.in             |  2 ++
>  tools/Makefile                 | 15 +++++++++++++--
>  tools/configure.ac             |  1 +
>  tools/ocaml/xenstored/Makefile |  1 +
>  5 files changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/Config.mk b/Config.mk
> index c8dac4c..3947e85 100644
> --- a/Config.mk
> +++ b/Config.mk
> @@ -208,6 +208,9 @@ LDFLAGS += $(foreach i, $(EXTRA_LIB), -L$(i))
>  CFLAGS += $(foreach i, $(EXTRA_INCLUDES), -I$(i))
>  LDFLAGS += $(foreach i, $(PREPEND_LIB), -L$(i))
>  CFLAGS += $(foreach i, $(PREPEND_INCLUDES), -I$(i))
> +ifeq ($(XEN_TOOLS_RPATH),y)
> +APPEND_LDFLAGS += -Wl,-rpath,$(LIBDIR)
> +endif

I thought APPEND_* was for user supplied things? Shouldn't this be just
LDFLAGS-$(XEN_TOOLS_RPATH) += -Wl,....

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel