Re: [Xen-devel] [PATCH 28/28] Separate runtime debug output from debug symbols

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.09.14 at 17:41, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 25/09/14 16:20, Olaf Hering wrote:
>> --- a/xen/Rules.mk
>> +++ b/xen/Rules.mk
>> @@ -43,7 +43,10 @@ ALL_OBJS-$(x86)          += $(BASEDIR)/crypto/built_in.o
>>  
>>  CFLAGS += -fno-builtin -fno-common
>>  CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith
>> -CFLAGS += -pipe -g -D__XEN__ -include $(BASEDIR)/include/xen/config.h
>> +ifeq ($(debug_symbols),y)
>> +CFLAGS += -g
>> +endif
>> +CFLAGS += -pipe -D__XEN__ -include $(BASEDIR)/include/xen/config.h
> 
> I am not sure this is correct.  Xen needs to embed its full symbol table
> for backtraces, so does need to be built unconditionally with -g

What does -g have to do with backtrace generation? If you're
after .debug_frame, that can be had as .eh_frame without -g (and
with -fasynchronous-unwind-tables passed instead). Yet whether
everyone wants this is not at all clear, so providing a knob to turn
it on/off seems quite desirable to me.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel