[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 28/28] Separate runtime debug output from debug symbols

>>> On 25.09.14 at 17:20, <olaf@xxxxxxxxx> wrote:
> With this change debug and debug_symbols is used consistently.
> With 'make debug=yn debug_symbols=yn' my rebuild time and diskspace
> usage goes down:
>    105275K clean xen.git checkout.
> y 1247041K build time: 5:57
> n  812112K build time: 5:34
> Two variables exist to control runtime and compiletime debug info:
> debug= for tools,stubdom,docs selects either -O1 or -O2 builds, and
> passes the flag down to qemu-upstream to enable additional runtime
> debugging.
> debug= for xen enables some asserts and extra checks in the code.
> debug_symbols= is used in few places to pass -g to gcc. Other places
> still pass -g unconditionally to gcc.
> Wrap all -g assigments to CFLAGS into debug_symbols==y.
> Pass --enable-debug-info --disable-strip to qemu-upstream build.
> Remove the --enable-debug configure option. Its now controlled by
> calling make with debug=yn and/or debug_symbols=yn for xen, tools and
> stubdom builds.

I'm having mixed feelings with this: On one hand it's nice to control
this on the command line. Otoh, since you don't force a full rebuild
when the setting changes between (incremental) builds, I'm not
certain a proper binary will result (or the build even succeed). Yes,
that's already a problem for the hypervisor build without this patch
(and I think such settings should only be passed through .config,
which should never be changed after an initial build), but extending
this doesn't necessarily seem like the right route.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.