[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for 4.5] xen/arm: p2m: Correctly initialize cur_offset

On Tue, 2014-09-30 at 15:51 +0100, Julien Grall wrote:
> {~0,} only initializes the first cell of the array to ~0. The other cells
> are initialized to 0.
> Change the initialization to a loop and, at the same time, do the same
> for the mappings.

I'm not sure a loop is the best option here vs either { ~0, ~0, ~0, ~0 }
or a memset, but OK.

I don't think mappings is wrong as it is though, any reason to change?

> This is fixing boot after 82985d7 "xen: arm: handle variable p2m levels
> in apply_p2m_changes" on platform where the root-level doesn't have
> concatenate table (such as the Foundation Model).

You forgot your S-o-b.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.