Re: [Xen-devel] [PATCH v18 08/10] x86: add CMT related MSRs in allowed list

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.10.14 at 12:59, <chao.p.peng@xxxxxxxxxxxxxxx> wrote:
> On Tue, Sep 30, 2014 at 02:26:35PM +0100, Jan Beulich wrote:
>> >>> On 30.09.14 at 12:49, <chao.p.peng@xxxxxxxxxxxxxxx> wrote:
>> > --- a/xen/include/asm-x86/msr-index.h
>> > +++ b/xen/include/asm-x86/msr-index.h
>> > @@ -324,6 +324,8 @@
>> >  #define MSR_IA32_ENERGY_PERF_BIAS 0x000001b0
>> >  
>> >  /* Platform Shared Resource MSRs */
>> > +#define MSR_IA32_QOSEVTSEL                0x00000c8d
>> 
>> Is this still an appropriate name with then name change "QOS" -> "CMT"?
>> 
>> > +#define MSR_IA32_QMC                      0x00000c8e
>> 
>> The Q here may similarly be questionable now.
>> 
>> >  #define MSR_IA32_PQR_ASSOC                0x00000c8f
>> 
>> And maybe even the one here?
>> 
>>
> 
> As the SDM still use the old names, I left these names unchanged so that
> no surprise for someone don't know the history to look into the spec.
> 
> So it's more like a spec issue.
> 
> On the other hand, I also feel the code here looks ugly. So maybe we can
> still change them to 'correct' ones?

If you can first internally agree on stable names going forward?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel