[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.5] libxc: fix mmap leak in xc_unmap_domain_meminfo/xc_map_domain_meminfo

On Wed, 2014-10-01 at 15:35 +0200, Vitaly Kuznetsov wrote:
> xc_unmap_domain_meminfo uses P2M_FLL_ENTRIES macro instead of P2M_FL_ENTRIES.
> Moreover, P2M_FL_ENTRIES macro uses (dinfo->p2m_size) which is always 0 here
> as we don't initialize it. The result is that we always unmap just 1 frame.
> xc_map_domain_meminfo uses P2M_FLL_ENTRIES macro instead of P2M_FL_ENTRIES
> on failure path.
> The issue went unnoticed mostly because we use unmap_domain_meminfo and
> xc_map_domain_meminfo in one-shot xen-mfndump and xen-hptool (through
> xc_exchange_page()) tools. When used is long-running apps (e.g. in xl)
> domains become zombies after their death.
> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>

Good catch. Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> and
applied, thanks!

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.