Re: [Xen-devel] [V2 3/3] amd/seattle: Initial revision of AMD Seattle support

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 02/10/2014 21:37, Suravee Suthikulpanit wrote:
> On 10/02/2014 02:04 PM, Suravee Suthikulpanit wrote:
> > > > +#include <asm/psci.h>
> > > > +
> > > > +static const char * const seattle_dt_compat[] __initconst =
> > > > +{
> > > > +    "amd,seattle",
> > > > +    NULL
> > > > +};
> > > > +
> > > > +/* Seattle firmware only implements PSCI handler for
> > > > + * system off and system reset at this point.
> > > > + * This is temporary until full PSCI-0.2 is supported.
> > > > + * Then, these function will be removed.
> > > > + */
> > > > +static noinline void seattle_smc_psci(register_t func_id)
> > > > +{
> > > > +    asm volatile(
> > > > +        "smc #0"
> > > > +        : "+r" (func_id)
> > > > +        :);
> > > > +}
> > > We already have multiple implementation of smc in different place. Can
> > > we provide a common function rather than adding another one?
> > The only place I found this is in the arch/arm/psci.c, which is used
> > mainly for the PSCI stuff. I can declare that one as non-static, and use
> > it here in the seattle.c.
> >
> > Suravee
> Julien,
>
> Actually, think about this again, I would rather keep this independent
> from the other PSCI patch series, which might not make it into 4.5.  It
> is small enough and probably not too terrible to keep this.
There is also one in xen/arch/arm/platforms/exynos.c (exynos_smc).

Moving this patch could be part of this series and I don't think it 
would be a showstopper for accepting it in 4.5.
Ian, any though?

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel