Re: [Xen-devel] [PATCH 3/4] xen/arm: introduce XENMEM_cache_flush

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-10-02 at 11:02 +0100, Stefano Stabellini wrote:
> +            if ( owner != d && !grant_map_exists(d, owner->grant_table, mfn) 
> )
> +            {
> +                printk(XENLOG_G_ERR "mfn %llx hasn't been granted by %d to 
> %d\n", mfn, owner->domain_id, d->domain_id);
> +                ret = -EINVAL;
> +                goto out;
> +            }

I know you are rewriting this as a gnttab op but this made me think to
mention: Be sure to consider the case of a loop back grant, i.e.
granting something to yourself. We do occasionally have call to loopback
attach e.g. vbd devices to dom0.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel