Re: [Xen-devel] [PATCH] mini-os: enable compiler check for printk format types

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sun, 2014-10-05 at 21:30 +0200, Samuel Thibault wrote:

> > Samuel, are you ok with the patch after those clarifications?
> 
> Yes.

I interpreted this as an Acked-by, I hope that's ok, and was about to
commit when:
disk_read.c: In function 'vtpm_load_disk':
disk_read.c:539:59: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 2 has type 'unsigned int' [-Werror=format]
disk_read.c:539:59: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 4 has type 'unsigned int' [-Werror=format]
disk_read.c:540:2: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 2 has type 'unsigned int' [-Werror=format]
disk_read.c:540:2: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 3 has type 'unsigned int' [-Werror=format]
disk_read.c:542:30: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 4 has type 'unsigned int' [-Werror=format]
disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 2 has type 'unsigned int' [-Werror=format]
disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 3 has type 'unsigned int' [-Werror=format]
disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 4 has type 'unsigned int' [-Werror=format]
disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 5 has type 'unsigned int' [-Werror=format]
disk_read.c:548:21: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 2 has type 'unsigned int' [-Werror=format]
disk_read.c:548:21: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 4 has type 'unsigned int' [-Werror=format]
disk_read.c:548:21: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 6 has type 'unsigned int' [-Werror=format]
disk_read.c:551:21: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 2 has type 'unsigned int' [-Werror=format]
disk_read.c:551:21: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 3 has type 'unsigned int' [-Werror=format]
disk_read.c:551:21: error: format '%lu' expects argument of type 'long unsigned 
int', but argument 5 has type 'unsigned int' [-Werror=format]

That's on an x86_32 stubdom build.

Looks like this is printing the output of sizeof. The correct modifier
for printing a size_t is %zu not hardcoded as a long. I haven't checked
if mini-os printf supports z.

> Reviewing it just kept being behind loads of stuff in my TODO list :/

I know the feeling :-/



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel