[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 00/28 v5 for-xen-4.5] tool changes to honor configure --prefix=DIR



On Wed, Oct 01, 2014 at 06:41:02PM +0200, Olaf Hering wrote:
> Konrad, you are in CC because I would like to see this in 4.5-rc1.

Thank you.
> 
> 
> In my attempt to get a xen.rpm from 'make rpmball' which operates
> entirely below the configured --prefix= I came up with these changes.

Released-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Regression wise it will be quite easy to figure out if something is broken -
it hasn't been built. Hence the error reporting of that should be fairly easy.

The benefit of this change is that it does an good cleanup of
Makefile/configure.ac and in the long term that should make it better
and easier to compile Xen on other platforms.

> 
> This is a resend of the remaining parts of this series with the
> comments incorporated:
> http://lists.xenproject.org/archives/html/xen-devel/2014-09/msg03003.html
> http://lists.xenproject.org/archives/html/xen-devel/2014-09/msg03981.html
> 
> In v5 of this series the --libexec patch was updated to also remove
> PRIVATE_PREFIX and PRIVATE_BINDIR from paths.m4, and it does not remove
> $(LIBDIR)/xen/ anymore - just $(LIBEXEC). The patch to "separate runtime
> debug info" is the simplified version.
> 
> 
> With this series its now possible to run everything except pygrub
> below the configured --prefix=.

Yeey!
> 
> NOTE: the renaming of tools/hotplug/Linux/init.d/xencommons.in may
> cause trouble in configured working copies. Use 'git clean -dfx' to
> wipe all and everything before git pull.
> 
> One outstanding bug is pygrub, which does not know about
> $prefix/$lib/python/site-packages. This is still on my todo list.
> 
> Please rerun autogen.sh after applying this series.
> 
> Olaf
> 
> 
> 
> Olaf Hering (28):
>   tools: fix make uninstall
>   tools/hotplug: fix race during xen.conf creation
>   tools/python: use also LDFLAGS for build
>   Add configure --with-initddir=DIR
>   tools/hotplug: use XEN_SCRIPT_DIR instead of hardcoded path
>   tools/configure.ac: sort AC_CONFIG_FILES
>   tools/hotplug: use INITD_DIR instead of CONFIG_DIR/init.d|rc.d
>   tools/hotplug: substitute XEN_SCRIPT_DIR on FreeBSD
>   remove duplicate variables from config
>   Substitue configure variables in Paths.mk.in
>   tools: substitute bindir instead of BINDIR
>   Use configure --mandir=DIR to set MANDIR
>   Use configure --docdir=DIR to set DOCDIR
>   Use configure --includedir=DIR to set INCLUDEDIR
>   Use configure --libexecdir=BASEDIR to set LIBEXEC
>   Use configure --prefix=DIR to set PREFIX
>   Use configure --localstatedir=BASEDIR to set path to /var
>   Add configure --enable-rpath
>   Add configure --with-linux-backend-modules="mod1 mod2"
>   Move variable to set bash_completion.d to Paths.mk
>   Add configure --with-sysconfig-leaf-dir=SUBDIR to set CONFIG_LEAF_DIR
>   Make XENFIRMWAREDIR a subdir of libexecdir
>   tools: remove private copies of includedir and libdir from libxenstat
>   Use Paths.mk for docs, stubdom and tools build
>   tools: use XEN_LIB_STORED instead of /var/lib/xenstored
>   tools/hotplug: Use XEN_RUN_DIR instead of /var/run/xen
>   move vtpmmgr helpers from tools to stubdom
>   Separate runtime debug output from debug symbols
> 
>  .gitignore                                         |   7 ++
>  Config.mk                                          |  14 +--
>  Makefile                                           |  12 ---
>  README                                             |  12 ---
>  config/Docs.mk.in                                  |   7 +-
>  config/Linux.mk                                    |   2 +
>  config/Linux.modules                               |  20 ----
>  config/NetBSD.mk                                   |   5 -
>  config/NetBSDRump.mk                               |   2 -
>  config/Paths.mk.in                                 |  44 +++++++--
>  config/StdGNU.mk                                   |  23 -----
>  config/Stubdom.mk.in                               |   7 --
>  config/SunOS.mk                                    |  15 ---
>  config/Tools.mk.in                                 |  13 +--
>  docs/misc/distro_mapping.txt                       |   5 +-
>  m4/paths.m4                                        | 101 
> ++++++++++++++-------
>  m4/xenstored.m4                                    |   8 +-
>  stubdom/Makefile                                   |   9 +-
>  stubdom/vtpmmgr/Makefile                           |   5 +
>  {tools => stubdom}/vtpmmgr/calc.pl                 |   0
>  {tools => stubdom}/vtpmmgr/manage-vtpmmgr.pl       |   0
>  tools/Makefile                                     |  46 ++++++++--
>  tools/Rules.mk                                     |   1 -
>  tools/configure.ac                                 |  53 +++++++++--
>  tools/console/Makefile                             |   4 +-
>  tools/hotplug/FreeBSD/Makefile                     |   5 +-
>  .../FreeBSD/rc.d/{xencommons => xencommons.in}     |   6 +-
>  tools/hotplug/FreeBSD/vif-bridge                   |   2 +-
>  tools/hotplug/Linux/Makefile                       |  18 ++--
>  tools/hotplug/Linux/init.d/sysconfig.xencommons.in |  10 +-
>  .../Linux/init.d/{xen-watchdog => xen-watchdog.in} |   2 +-
>  .../init.d/{xencommons.in.in => xencommons.in}     |  13 ++-
>  .../Linux/init.d/{xendomains => xendomains.in}     |  14 +--
>  tools/hotplug/Linux/systemd/Makefile               |  37 ++------
>  .../systemd/xen-qemu-dom0-disk-backend.service.in  |   4 +-
>  .../hotplug/Linux/systemd/xen-watchdog.service.in  |   2 +-
>  tools/hotplug/Linux/systemd/xenconsoled.service.in |   2 +-
>  tools/hotplug/Linux/systemd/xendomains.service.in  |   6 +-
>  tools/hotplug/Linux/systemd/xenstored.service.in   |   4 +-
>  tools/hotplug/Linux/update-modules.sh              |  36 --------
>  tools/hotplug/Linux/{vif-setup => vif-setup.in}    |   2 +-
>  .../{xen-backend.rules => xen-backend.rules.in}    |  16 ++--
>  ...-hotplug-common.sh => xen-hotplug-common.sh.in} |   4 +-
>  tools/hotplug/Linux/{xendomains => xendomains.in}  |   2 +-
>  tools/hotplug/NetBSD/Makefile                      |   6 +-
>  tools/hotplug/NetBSD/block                         |   2 +-
>  .../NetBSD/rc.d/{xencommons => xencommons.in}      |   4 +-
>  tools/hotplug/NetBSD/vif-bridge                    |   2 +-
>  tools/hotplug/NetBSD/vif-ip                        |   2 +-
>  tools/libxl/Makefile                               |   6 +-
>  tools/libxl/libxl_dm.c                             |   4 +-
>  tools/libxl/libxl_internal.h                       |   1 -
>  tools/libxl/libxl_paths.c                          |   7 +-
>  tools/libxl/libxl_save_callout.c                   |   2 +-
>  tools/misc/Makefile                                |   4 +-
>  tools/ocaml/common.make                            |   5 +-
>  tools/pygrub/Makefile                              |   8 +-
>  tools/python/Makefile                              |   4 +-
>  tools/vtpmmgr/Makefile                             |  15 ---
>  tools/xcutils/Makefile                             |   4 +-
>  tools/xenpaging/Makefile                           |   4 +-
>  tools/xenstat/libxenstat/Makefile                  |   4 -
>  tools/xenstore/Makefile                            |   3 +-
>  tools/xenstore/xs_lib.c                            |   2 +-
>  tools/xentrace/Makefile                            |   4 +-
>  xen/Rules.mk                                       |   3 +-
>  66 files changed, 322 insertions(+), 374 deletions(-)
>  delete mode 100644 config/Linux.modules
>  rename {tools => stubdom}/vtpmmgr/calc.pl (100%)
>  rename {tools => stubdom}/vtpmmgr/manage-vtpmmgr.pl (100%)
>  rename tools/hotplug/FreeBSD/rc.d/{xencommons => xencommons.in} (96%)
>  rename tools/hotplug/Linux/init.d/{xen-watchdog => xen-watchdog.in} (97%)
>  rename tools/hotplug/Linux/init.d/{xencommons.in.in => xencommons.in} (91%)
>  rename tools/hotplug/Linux/init.d/{xendomains => xendomains.in} (79%)
>  delete mode 100755 tools/hotplug/Linux/update-modules.sh
>  rename tools/hotplug/Linux/{vif-setup => vif-setup.in} (61%)
>  rename tools/hotplug/Linux/{xen-backend.rules => xen-backend.rules.in} (62%)
>  rename tools/hotplug/Linux/{xen-hotplug-common.sh => 
> xen-hotplug-common.sh.in} (94%)
>  rename tools/hotplug/Linux/{xendomains => xendomains.in} (99%)
>  rename tools/hotplug/NetBSD/rc.d/{xencommons => xencommons.in} (97%)
>  delete mode 100644 tools/vtpmmgr/Makefile
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.