[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Blocking CR and MSR writes via mem_access?

  • To: Jan Beulich <JBeulich@xxxxxxxx>, Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Tue, 07 Oct 2014 15:48:40 +0300
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxx>
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Tue, 07 Oct 2014 12:47:52 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=lzLws909qWMc+cVwco9QcKw3pastCjxtvkhr1/RrhW+yuOrtSdJ67/yJAcrK5GTNcXUWoNk2VdJnkwWpei1fSMMyk3pJ6/tAA/N0cPZCvh+om6WAmOhGYyV/WiMMHk9gQ1FbDI/TkumOvd+qumdgYo/MZfLBnzYykTOZfpWr2cLHKi+BRf6OCiiNMH0ovu8wpJBekmKweYvT8UcLX6faT1uywk4kAuhKNQcyr9uY5iLdczzgDRwQ95gkVHfYcXEmuoIAtG+NlQ+lniYlU6VbUuvPvHV5JMs9cNazs4qyIvkZQvpTIuWdns1cqGVShG6L4AW+FZcaaxh7SBSO5lz8sg==; h=Received:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 10/07/2014 03:40 PM, Jan Beulich wrote:
>>>> On 07.10.14 at 14:30, <tamas.lengyel@xxxxxxxxxxxx> wrote:
>> IMHO that entire struct is in dire need of a cleanup. It is really hacky to
>> have fields like gla and gfn transfer values that mean different things
>> under different event type that don't have anything to do with gla/gfn.
>> It's sort of just a legacy struct from the time when we only had EPT events
>> and everything else just got hacked on top. I would be in favor of having
>> the struct as a union of substructs that nicely define all the values that
>> are transferred in the given context, with meaningful struct member names.
> And the whole thing isn't just "mem-event" anymore either ...

I agree with the union improvement, and indeed, we might need a more
appropriate name for the whole thing (xen-event?).

I guess one question would be how this would impact existing clients,
but there probably aren't that many, and the changes required to replace
the .gla / .gfn logic should be minimal.

Razvan Cojocaru

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.