[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-xen-4.5] Remove dead qemu code from toplevel Makefile

On Wed, 2014-10-08 at 09:41 +0200, Olaf Hering wrote:
> After commit b0f69ec5c71de1248d915c193b57c43e786857dd ("tools: Make
> qemu-xen-traditional build optional.") the existing make targets are
> wrapped in ifeq ($(CONF),y), but CONF is never set because
> config/Tools.mk is not included.
> Drop the dead code. The same effect can be achieved by calling the make
> commands directly, after calling configure.
> A better approach would be a simple, single 'make $something' which
> should be a wrapper around a targets in tools/Makefile that clones,
> updates and cleans the subprojects. That has to be worked out in a
> different patch.
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>

Nothing can possibly be using these (at least not successfully), so
acked + applied.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.