Re: [Xen-devel] [RFC PATCH 08/13] xen/dts: make the dt_find_property function to be global

[Oleksandr Dmytryshyn <oleksandr.dmytryshyn@xxxxxxxxxxxxxxx>]

On Tue, Oct 7, 2014 at 6:09 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> Hi Oleksandr,
>
> On 10/07/2014 03:19 PM, Oleksandr Dmytryshyn wrote:
>> This patch makes possible to use the dt_find_property function
>> outside the device tree module.
>
> I can't find any usage of this function within your series. Any reason
> to export it?
This function is used by patch in this series
([RFC PATCH 09/13] arch/arm: create device tree nodes for Dom0 cpufreq
cpu drive).

> Regards,
>
>> Signed-off-by: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@xxxxxxxxxxxxxxx>
>> ---
>>  xen/common/device_tree.c      | 2 +-
>>  xen/include/xen/device_tree.h | 9 +++++++++
>>  2 files changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
>> index f0bd7b9..5fbb0c1 100644
>> --- a/xen/common/device_tree.c
>> +++ b/xen/common/device_tree.c
>> @@ -522,7 +522,7 @@ static void __init *unflatten_dt_alloc(unsigned long 
>> *mem, unsigned long size,
>>  }
>>
>>  /* Find a property with a given name for a given node and return it. */
>> -static const struct dt_property *
>> +const struct dt_property *
>>  dt_find_property(const struct dt_device_node *np,
>>                   const char *name,
>>                   u32 *lenp)
>> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
>> index 99de53f..508d840 100644
>> --- a/xen/include/xen/device_tree.h
>> +++ b/xen/include/xen/device_tree.h
>> @@ -344,6 +344,15 @@ struct dt_device_node *dt_find_compatible_node(struct 
>> dt_device_node *from,
>>
>>  /**
>>   * Find a property with a given name for a given node
>> + * and return it.
>> + */
>> +const struct dt_property *dt_find_property(const struct dt_device_node *np,
>> +                                           const char *name,
>> +                                           u32 *lenp);
>> +
>> +
>> +/**
>> + * Find a property with a given name for a given node
>>   * and return the value.
>>   */
>>  const void *dt_get_property(const struct dt_device_node *np,
>>
>
>
> --
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel