Re: [Xen-devel] [PATCH v7 for-4.5 1/7] libxl: replace memset() with libxl__device_console_init

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Oct 09, 2014 at 10:17:26AM +0100, David Scott wrote:
> The current implementation of libxl__device_console_init does the same
> memset() so this is identical for now.
> 
> If libxl__device_console_init changes in future (e.g. to prefer a non-zero
> default value for some field) then this will continue to work.
> 
> Signed-off-by: David Scott <dave.scott@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
>  tools/libxl/libxl_create.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index 8b82584..543c1b3 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -389,7 +389,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
>  
>  static int init_console_info(libxl__device_console *console, int dev_num)
>  {
> -    memset(console, 0x00, sizeof(libxl__device_console));
> +    libxl__device_console_init(console);
>      console->devid = dev_num;
>      console->consback = LIBXL__CONSOLE_BACKEND_XENCONSOLED;
>      console->output = strdup("pty");
> -- 
> 1.7.10.4

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel