Re: [Xen-devel] [PATCH for-xen-4.5 v3 02/16] x86/boot/reloc: Move typedef and include to beginning of file

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 08/10/14 18:52, Daniel Kiper wrote:
> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

(FWIW, this would be find IMO folded into the previous patch as part of
a "misc cleanup to reloc.c" patch)

> ---
>  xen/arch/x86/boot/reloc.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/x86/boot/reloc.c
> index 4609e55..0c03291 100644
> --- a/xen/arch/x86/boot/reloc.c
> +++ b/xen/arch/x86/boot/reloc.c
> @@ -10,6 +10,10 @@
>   *    Keir Fraser <keir@xxxxxxx>
>   */
>  
> +typedef unsigned int u32;
> +
> +#include "../../../include/xen/multiboot.h"
> +
>  /* entered with %eax = BOOT_TRAMPOLINE */
>  asm (
>      "    .text                         \n"
> @@ -30,9 +34,6 @@ asm (
>      "    .long 0                       \n"
>      );
>  
> -typedef unsigned int u32;
> -#include "../../../include/xen/multiboot.h"
> -
>  static void *reloc_mbi_struct(void *old, unsigned int bytes)
>  {
>      void *new;


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel