[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 12/44] mfd: ab8500-sysctrl: Register with kernel poweroff handler
- To: Lee Jones <lee.jones@xxxxxxxxxx>
- From: Guenter Roeck <linux@xxxxxxxxxxxx>
- Date: Thu, 9 Oct 2014 08:54:04 -0700
- Cc: "linux-m32r-ja@xxxxxxxxxxxxxxxxx" <linux-m32r-ja@xxxxxxxxxxxxxxxxx>, "linux-mips@xxxxxxxxxxxxxx" <linux-mips@xxxxxxxxxxxxxx>, "linux-m68k@xxxxxxxxxxxxxxx" <linux-m68k@xxxxxxxxxxxxxxx>, "linux-efi@xxxxxxxxxxxxxxx" <linux-efi@xxxxxxxxxxxxxxx>, "linux-ia64@xxxxxxxxxxxxxxx" <linux-ia64@xxxxxxxxxxxxxxx>, "linux-sh@xxxxxxxxxxxxxxx" <linux-sh@xxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, "devicetree@xxxxxxxxxxxxxxx" <devicetree@xxxxxxxxxxxxxxx>, "devel@xxxxxxxxxxxxxxxxxxxx" <devel@xxxxxxxxxxxxxxxxxxxx>, "linux-s390@xxxxxxxxxxxxxxx" <linux-s390@xxxxxxxxxxxxxxx>, "lguest@xxxxxxxxxxxxxxxx" <lguest@xxxxxxxxxxxxxxxx>, "linux-c6x-dev@xxxxxxxxxxxxx" <linux-c6x-dev@xxxxxxxxxxxxx>, "linux-hexagon@xxxxxxxxxxxxxxx" <linux-hexagon@xxxxxxxxxxxxxxx>, "linux-acpi@xxxxxxxxxxxxxxx" <linux-acpi@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-xtensa@xxxxxxxxxxxxxxxx" <linux-xtensa@xxxxxxxxxxxxxxxx>, "user-mode-linux-devel@xxxxxxxxxxxxxxxxxxxxx" <user-mode-linux-devel@xxxxxxxxxxxxxxxxxxxxx>, "linux-pm@xxxxxxxxxxxxxxx" <linux-pm@xxxxxxxxxxxxxxx>, "adi-buildroot-devel@xxxxxxxxxxxxxxxxxxxxx" <adi-buildroot-devel@xxxxxxxxxxxxxxxxxxxxx>, "linux-am33-list@xxxxxxxxxx" <linux-am33-list@xxxxxxxxxx>, "linux-tegra@xxxxxxxxxxxxxxx" <linux-tegra@xxxxxxxxxxxxxxx>, "openipmi-developer@xxxxxxxxxxxxxxxxxxxxx" <openipmi-developer@xxxxxxxxxxxxxxxxxxxxx>, "linux-metag@xxxxxxxxxxxxxxx" <linux-metag@xxxxxxxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>, "linux-cris-kernel@xxxxxxxx" <linux-cris-kernel@xxxxxxxx>, "linux-parisc@xxxxxxxxxxxxxxx" <linux-parisc@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-alpha@xxxxxxxxxxxxxxx" <linux-alpha@xxxxxxxxxxxxxxx>, "linuxppc-dev@xxxxxxxxxxxxxxxx" <linuxppc-dev@xxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 09 Oct 2014 15:54:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Thu, Oct 09, 2014 at 11:49:27AM +0100, Lee Jones wrote:
> On Thu, 09 Oct 2014, Catalin Marinas wrote:
>
> > On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote:
> > > On Mon, 06 Oct 2014, Guenter Roeck wrote:
> > > > --- a/drivers/mfd/ab8500-sysctrl.c
> > > > +++ b/drivers/mfd/ab8500-sysctrl.c
> > > > @@ -6,6 +6,7 @@
> > >
> > > [...]
> > >
> > > > +static int ab8500_power_off(struct notifier_block *this, unsigned long
> > > > unused1,
> > > > + void *unused2)
> > > > {
> > > > sigset_t old;
> > > > sigset_t all;
> > > > @@ -34,11 +36,6 @@ static void ab8500_power_off(void)
> > > > struct power_supply *psy;
> > > > int ret;
> > > >
> > > > - if (sysctrl_dev == NULL) {
> > > > - pr_err("%s: sysctrl not initialized\n", __func__);
> > > > - return;
> > > > - }
> > >
> > > Can you explain the purpose of this change please?
> >
> > I guess it's because the sysctrl_dev is already initialised when
> > registering the power_off handler, so there isn't a way to call the
> > above function with a NULL sysctrl_dev. Probably even with the original
> > code you didn't need this check (after some race fix in
> > ab8500_sysctrl_remove but races is one of the things Guenter's patches
> > try to address).
>
> Sounds reasonable, although I think this change should be part of
> another patch.
>
Turns out the options are to either drop the check or to use the device
managed function to register the poweroff handler. I decided to keep
the check and use the device managed function.
Guenter
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|