[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/hvm: implement save/restore for posted interrupts



Olaf Hering wrote on 2014-10-09:
> On Thu, Oct 09, Olaf Hering wrote:
> 
>> On Thu, Oct 09, Zhang, Yang Z wrote:
>> 
>>> +    for ( vector = 0; vector < NR_VECTORS; vector++ )
>>> +        if (vlapic_test_vector(vector, &s->regs->data[APIC_TMR]))
>>> +            set_bit(vector,  v->arch.hvm_vmx.eoi_exit_bitmap);
>> 
>> Did you send out the wrong version a few weeks ago? I tested the old

Indeed, the previous version is wrong.:( That also explains why it always fails 
to work on your side but works to me.

>> patch at that time. Now I notice the new version has this change:
>> 
>> -        if (vlapic_test_vector(vector, &s->regs->data[APIC_ISR]))$
>> +        if (vlapic_test_vector(vector, &s->regs->data[APIC_TMR]))$
>> 
>> I will try the new version.
> 
> Yes, this change finally worked also for me. Thanks!

Great! I will refine it and send out the formal version.

> 
> 
> Olaf


Best regards,
Yang


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.