Re: [Xen-devel] [PATCH for-xen-4.5] Add configure --with-extra-cflags-*

[Olaf Hering <olaf@xxxxxxxxx>]

On Thu, Oct 09, Olaf Hering wrote:

> +AC_ARG_WITH([extra-cflags-tools],
> +    AS_HELP_STRING([--with-extra-cflags-tools="EXTRA_CFLAGS"],
> +       [Additional CFLAGS to be used to build tools.]),
> +       [EXTRA_CFLAGS_XEN_TOOLS=$withval],
> +       [EXTRA_CFLAGS_XEN_TOOLS=])
> +AC_SUBST(EXTRA_CFLAGS_XEN_TOOLS)

I wonder why all the other --with-foo are not done that way as well. It
looks like they would take the variable from the environment and do
AC_SUBST(). IMO private variables like seabios_path, ovmf_path,
EXTRA_QEMUU_CONFIGURE_ARGS should not be passed via environment. I also
question if --with-foo=no is useful at all. My suggestion is to convert
these three to the style quoted above: a --with-foo=val assigns $val to
the given private variable, otherwise the private variable is
initialized empty.

What do you think?

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel