Re: [Xen-devel] [PATCH v3 3/5] xen/x86: introduce more cache maintenance operations

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.10.14 at 15:00, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> --- a/xen/include/asm-x86/page.h
> +++ b/xen/include/asm-x86/page.h
> @@ -346,6 +346,10 @@ static inline uint32_t cacheattr_to_pte_flags(uint32_t 
> cacheattr)
>  
>  /* No cache maintenance required on x86 architecture. */
>  static inline void flush_page_to_ram(unsigned long mfn) {}
> +static inline void clean_xen_dcache_va_range(const void *p, unsigned long 
> size) {}
> +static inline void invalidate_xen_dcache_va_range(const void *p, unsigned 
> long size) {}
> +static inline void clean_and_invalidate_xen_dcache_va_range
> +    (const void *p, unsigned long size) {}

Mind explaining what purpose the "_xen" in these names serves?
Also, is simply stubbing these out correct? I.e. there are caches on
x86, and those can both be invalidated and cleaned, so why would
you not do so here?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel