[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Possible bug in tools/libxl/libxl.c -- Variable passed by reference not set in one possible case

Please send plain text email in the future. Some (if not all) developers
only have very shabby text editor to read / reply to your email. ;-)

On Thu, Oct 09, 2014 at 08:28:53PM -0500, ayush ruia wrote:
> What I am trying to say is that shouldn't the code block highlighted in
> yellow should come before the block marked in green. Then it would update
> the value of *target_memkb and *max_memkb in all possible situations.

I don't think so. This function means "if there's no such values in
xenstore then retrieve them from hypervisor and fill them in xenstore,
optionally return those values to the caller".

So if those values already are present in xenstore this function doesn't
need to do anything.

Probably looking at its call sites can help you understand better.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.