Re: [Xen-devel] [PATCH] tools/hotplug/Linux: Fix build

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Oct 10, 2014 at 09:44:38AM +0100, Ian Campbell wrote:
[...]
> Should subdirs-install depend on subdirs-all perhaps?
> 
> commit 66bb8b04f0032ddf0aa007b0850be1ec15477d60
> Author: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Date:   Fri Oct 10 09:35:34 2014 +0100
> 
>     Revert "tools/hotplug: fix race during xen.conf creation"
>     
>     This reverts commit eac3f5122fd4769b2885d8ad78bcbcf5df2472c1.
>     
>     The "all" target should never depend on "install", it is supposed to only 
> build
>     not install.
>     
>     Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> diff --git a/tools/hotplug/Linux/systemd/Makefile 
> b/tools/hotplug/Linux/systemd/Makefile
> index 6950d24..9c58b33 100644
> --- a/tools/hotplug/Linux/systemd/Makefile
> +++ b/tools/hotplug/Linux/systemd/Makefile
> @@ -21,11 +21,10 @@ ALL_XEN_SYSTEMD = $(XEN_SYSTEMD_MODULES)  \
>                       $(XEN_SYSTEMD_SERVICE)
>  
>  .PHONY: all
> -all: install
> +all: $(ALL_XEN_SYSTEMD)
>  
>  .PHONY: clean
>  clean:
> -     rm -f $(ALL_XEN_SYSTEMD)
>  

Now clean target just becomes empty...

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel