Re: [Xen-devel] [PATCH RFC OSSTEST 05/19] ts-host-install: Add fdtdir to PXE stanza if dtbs directory exists

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH RFC OSSTEST 05/19] ts-host-install: Add fdtdir to 
PXE stanza if dtbs directory exists"):
> u-boot's pxe client uses this together with $fdtfile in its local environment
> to automatically load the fdt when pxe booting.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Although, bikeshedding,

> +    my $dtbs = "fdtdir /$d_i/dtbs" if
> +     -e "$ho->{Tftp}{Path}/$d_i/dtbs";
> +

the if at the end of the line strikes me as a slightly odd style.
There are many fewer of those in the codebase right now than places
where it's on the start and the next line.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel