Re: [Xen-devel] [PATCH RFC OSSTEST 14/19] Osstest/Debian: Support for loading an FDT from u-boot script

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH RFC OSSTEST 14/19] Osstest/Debian: Support for 
loading an FDT from u-boot script"):
> The currently supported platform provides an FDT preloaded at
> 0x1000. Replace this with ${fdt_addr} (which the current platform
> exposes) and for platforms which do not provide an fdt arrange to
> load the relevant file as named in the ${fdtfile} (which is
> conventionally provided by u-boot for platforms which need this).

You should mention the extra `echo's in the commit message.

You have two copies of the same dtb-loading code.  (You had two copies
of the `scsi scan' and `mw.l' previously, but this is now worse
because it's bigger.)

I confess I don't really understand some of this.  `Platforms which do
not provide an fdt' are ones where ${fdt_addr} is empty ?  And on
those platforms `fdt addr \${fdt_addr}' is a no-op ?

You might find the code clearer (less toothpick-counting) if you used
<<'delim' for some of it, at one or other of the levels.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel