Re: [Xen-devel] [PATCH for-xen-4.5] Fix configure --with-systemd-modules-load=DIR

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-10-10 at 17:21 +0200, Olaf Hering wrote:
> On Fri, Oct 10, Ian Jackson wrote:
> 
> > Olaf Hering writes ("[PATCH for-xen-4.5] Fix configure 
> > --with-systemd-modules-load=DIR"):
> > > Currently --with-systemd=DIR1 --with-systemd-modules-load=DIR2 will set
> > > both XEN_SYSTEMD_DIR and XEN_SYSTEMD_MODULES_LOAD to DIR1. The reason is
> > > that both AC_ARG_WITH() use 'systemd' as the name for the internal
> > > variable. As a result the value of the first option is also use as the
> > > value for the second option. Fix this by using another variable name.
> > ...
> > > - AC_ARG_WITH(systemd,
> > > + AC_ARG_WITH(systemd_modules_load,
> > 
> > AFAICT this changes the command line option.  I don't understand how
> > --with-systemd-modules-load worked at all before this.
> 
> It did not, at least I was able to change the variable to the desired
> value. But you are right, sysconfig-leaf-dir in another file does not
> have underscores. Do you want me to resend, or will you fix it up
> manually to systemd-modules-load once you merge it?

Best to have a new patch for something not related to this one please.

Ian



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel