[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] arm32: fix build after 063188f4b3

>>> On 10.10.14 at 17:55, <julien.grall@xxxxxxxxxx> wrote:
> On 10/10/2014 15:51, Jan Beulich wrote:
>>>>> On 10.10.14 at 16:12, <julien.grall@xxxxxxxxxx> wrote:
>>> This function is duplicate in 3 different places in Xen:
>>>     - arch/arm/psci.c
>>>     - arch/platforms/exynos5.c
>>>     - arch/platforms/seattle.c
>>> So all those functions should be fixed. I think it's time to introduce a
>>> global SMC function...
>> Okay, I got the build failure only in this one place. But if and when
>> the compiler choses to do such transformations is entirely up to it,
>> so yes, if there are multiple instances likely they all would need
>> fixing.
> BTW,  named register is a GNU extension and not supported by clang. Can 
> you avoid to use them? Maybe by writing the function in assembly. So we 
> are safe against any compiler optimization.

I don't think I'm the right one to write ARM assembly code at this
point. I really just want the build fixed - anything beyond that I'd
rather leave to you guys.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.