[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v13 for-xen-4.5 07/21] x86/VPMU: Handle APIC_LVTPC accesses

>>> On 03.10.14 at 23:40, <boris.ostrovsky@xxxxxxxxxx> wrote:
> @@ -706,10 +693,6 @@ static int core2_vpmu_do_interrupt(struct cpu_user_regs 
> *regs)
>              return 0;
>      }
> -    /* HW sets the MASK bit when performance counter interrupt occurs*/
> -    vpmu->hw_lapic_lvtpc = apic_read(APIC_LVTPC) & ~APIC_LVT_MASKED;
> -    apic_write_around(APIC_LVTPC, vpmu->hw_lapic_lvtpc);

So why is simply deleting this correct? The comment makes pretty
clear why it was being done here. All I could see being valid without
further explanation is the removal of the middle of the three lines.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.