Re: [Xen-devel] [PATCH v2 for 4.5] arm32: fix build after 063188f4b3

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Jan,

On 10/13/2014 04:51 PM, Jan Beulich wrote:
>>>> On 13.10.14 at 17:29, <julien.grall@xxxxxxxxxx> wrote:
>> --- /dev/null
>> +++ b/xen/arch/arm/arm32/smc.S
>> @@ -0,0 +1,19 @@
>> +/*
>> + * xen/arch/arm/arm32/smc.S
>> + *
>> + * Wrapper for Secure Monitors Calls
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +
>> +GLOBAL(do_smc)
>> +        smc   #0
>> +        mov   pc, lr
> 
> If you defined a little "ret" helper macro there wouldn't be a need
> for separate files for 32- and 64-bit.

Good point. I will give a look to this solution.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel