[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 for 4.5] arm32: fix build after 063188f4b3

On 10/14/2014 05:29 PM, Jan Beulich wrote:
>>>> On 14.10.14 at 17:52, <julien.grall@xxxxxxxxxx> wrote:
>> "xen: arm: Add support for the Exynos secure firmware" introduced code
>> assuming that exynos_smc() would get called with arguments in certain
>> registers. While the "noinline" attribute guarantees the function to
>> not get inlined, it does not guarantee that all arguments arrive in the
>> assumed registers: gcc's interprocedural analysis can result in clone
>> functions to be created where some of the incoming arguments (commonly
>> when they have constant values) get replaced by putting in place the
>> respective values inside the clone.
>> Xen contains in multiple place of this SMC function: consolidate the 
>> function
>> in a single place and write it in assembly.
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> This is a fix for Xen 4.5 to compile the hypervisor with GCC 4.9.1, used by
>> Fedora & co.
>> Jan: I kept your Signed-off-by for the commit message.
>> Changes in v2:
>>     - Write the SMC call in assembly
>>     - Consolidate the code in a single place
> To me it very much looks like (not just because of the subject) you
> sent v2 again, rather than v3.

Oh right. I will send the v3 in a couple of minutes.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.