Re: [Xen-devel] [PATCH v3 for 4.5] arm32: fix build after 063188f4b3

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 10/15/2014 09:11 AM, Ian Campbell wrote:
> On Tue, 2014-10-14 at 17:32 +0100, Julien Grall wrote:
>> @@ -263,7 +250,7 @@ static int exynos5_cpu_up(int cpu)
>>      iounmap(power);
>>  
>>      if ( secure_firmware )
>> -        exynos_smc(SMC_CMD_CPU1BOOT, cpu, 0, 0);
>> +        call_smc1(SMC_CMD_CPU1BOOT, cpu);
>>  
> 
> Have you confirmed that none of these zeroes (throughout the patch, not
> just here) are actually unused and not just formal parameters which
> happen to be zero.

I can't find any documentation the exynos SMC call on the web.

I will send a new version by removing call_smc<n> and always use
call_smc with 4 parameters.

>> +#elif defined(CONFIG_ARM_64)
>> +/* Not specific ARM64 macros for now */
> 
> "No specific..."

Ok.

>> +
>> +int do_smc(register_t function_id, ...);
> 
> Stray?

Yes.


-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel