Re: [Xen-devel] [PATCH for-xen-4.5 v3 00/16] xen: Break multiboot (v1) dependency and add multiboot2 support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.10.14 at 17:33, <daniel.kiper@xxxxxxxxxx> wrote:
> On Thu, Oct 16, 2014 at 02:41:45PM +0100, Jan Beulich wrote:
>> And then I'm still not really convinced that all this goes in the right
>> direction. In particular I'm worried about you doing pretty invasive
>> to early boot code when it's not really clear that all this need to be
>> touched (and largely re-written). I'd really favor you initially working
>> towards supporting MB2 without at the same time trying to abstract
> 
> I have a feeling that if we go in that direction that this strong
> dependency on MB1 never would be broken.
> 
>> things to fit all of MB1, EFI, MB2, and eventually even ARM. This is
>> to a good part that it's currently rather hard to see whether what
>> you abstract and how are really the right items and mechanisms.
> 
> As said earlier, I think that we should break MB1 dependency first
> and use this work for further MB2 development. It pays. Please, look
> at patch which introduce MB2. It is very easy to do after my changes
> (introducing MBD and boot_info). Just one very simple patch. We do not
> even touch Xen main code! I am sure that it could be more difficult
> if we try to do that on currently exiting MB1 code.

Pretty strange way of looking at this: Of course everything can become
a 1-liner if dozens of intrusive preparatory patches set the stage right.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel