Re: [Xen-devel] [RFC PATCH v2 06/12] cpufreq: make cpufreq driver more generalizable

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.10.14 at 13:27, <oleksandr.dmytryshyn@xxxxxxxxxxxxxxx> wrote:
> --- a/xen/drivers/cpufreq/cpufreq.c
> +++ b/xen/drivers/cpufreq/cpufreq.c
> @@ -43,9 +43,14 @@
>  #include <asm/io.h>
>  #include <asm/processor.h>
>  #include <asm/percpu.h>
> -#include <acpi/acpi.h>
>  #include <xen/cpufreq.h>

I can see this being moved into a #ifdef CONFIG_ACPI section, but
removing it altogether seems kind of wrong.

> +#ifdef CONFIG_ACPI
> +    #define XEN_PX_FULL_INIT (XEN_PX_PCT | XEN_PX_PSS | XEN_PX_PSD | 
> XEN_PX_PPC)
> +#else
> +    #define XEN_PX_FULL_INIT (XEN_PX_PSS | XEN_PX_PSD | XEN_PX_PPC)
> +#endif

I'm not really understanding what is ACPI-specific about PCT but not
any of the other three. Please give some explanation in the commit
description.

Also if you want to use any kind of indentation for preprocessor
directives, please use

# define

(i.e. keep the # at the first column).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel