Re: [Xen-devel] [edk2] [PATCH v3 03/19] OvmfPkg: Add basic skeleton for the XenBus bus driver.

[Jordan Justen <jordan.l.justen@xxxxxxxxx>]

On 2014-10-17 10:03:46, Anthony PERARD wrote:
> This includes Component Name and Driver Binding.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> 
> ---
> Change in V3:
> - enable compilation for Ia32 and Ia32X64
> - fix version (driver binding)
> 
> Change in V2:
> - Simple support of controller name.
> - Cleaning up comments, files header.
> - Add Licenses
> - Rename XenbusDxe to XenBusDxe.
> ---
>  OvmfPkg/OvmfPkgIa32.dsc           |   1 +
>  OvmfPkg/OvmfPkgIa32.fdf           |   1 +
>  OvmfPkg/OvmfPkgIa32X64.dsc        |   1 +
>  OvmfPkg/OvmfPkgIa32X64.fdf        |   1 +
>  OvmfPkg/OvmfPkgX64.dsc            |   1 +
>  OvmfPkg/OvmfPkgX64.fdf            |   1 +
>  OvmfPkg/XenBusDxe/ComponentName.c | 190 +++++++++++++++++++++++
>  OvmfPkg/XenBusDxe/ComponentName.h | 110 +++++++++++++
>  OvmfPkg/XenBusDxe/DriverBinding.h | 144 +++++++++++++++++
>  OvmfPkg/XenBusDxe/XenBusDxe.c     | 317 
> ++++++++++++++++++++++++++++++++++++++
>  OvmfPkg/XenBusDxe/XenBusDxe.h     |  93 +++++++++++
>  OvmfPkg/XenBusDxe/XenBusDxe.inf   |  56 +++++++
>  12 files changed, 916 insertions(+)
>  create mode 100644 OvmfPkg/XenBusDxe/ComponentName.c
>  create mode 100644 OvmfPkg/XenBusDxe/ComponentName.h
>  create mode 100644 OvmfPkg/XenBusDxe/DriverBinding.h
>  create mode 100644 OvmfPkg/XenBusDxe/XenBusDxe.c
>  create mode 100644 OvmfPkg/XenBusDxe/XenBusDxe.h
>  create mode 100644 OvmfPkg/XenBusDxe/XenBusDxe.inf

> diff --git a/OvmfPkg/XenBusDxe/ComponentName.c 
> b/OvmfPkg/XenBusDxe/ComponentName.c
> new file mode 100644
> index 0000000..bcf1e51
> --- /dev/null
> +++ b/OvmfPkg/XenBusDxe/ComponentName.c
> @@ -0,0 +1,190 @@
> +/** @file
> +  Component Name functions implementation for XenBus Bus driver.
> +
> +  Copyright (C) 2014, Citrix Ltd.
> +
> +  Redistribution and use in source and binary forms, with or without
> +  modification, are permitted provided that the following conditions
> +  are met:
> +
> +  * Redistributions of source code must retain the above copyright
> +    notice, this list of conditions and the following disclaimer.
> +  * Redistributions in binary form must reproduce the above copyright
> +    notice, this list of conditions and the following disclaimer in
> +    the documentation and/or other materials provided with the
> +    distribution.
> +
> +  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +  "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +  LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> +  FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> +  COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> +  INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
> +  BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> +  LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
> +  CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> +  LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
> +  ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> +  POSSIBILITY OF SUCH DAMAGE.

This appears to match the 2-clause BSD license like the rest of EDK
II. Any reason to not follow the commonly used file header text?
"""
  This program and the accompanying materials
  are licensed and made available under the terms and conditions of the BSD 
License
  which accompanies this distribution.  The full text of the license may be 
found at
  http://opensource.org/licenses/bsd-license.php

  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
"""

> diff --git a/OvmfPkg/XenBusDxe/XenBusDxe.inf b/OvmfPkg/XenBusDxe/XenBusDxe.inf
> new file mode 100644
> index 0000000..25fd2f6
> --- /dev/null
> +++ b/OvmfPkg/XenBusDxe/XenBusDxe.inf
> @@ -0,0 +1,56 @@
> +
> +## @file
> +#  TODO: Brief Description of UEFI Driver XenBusDxe
> +#
> +#  TODO: Detailed Description of UEFI Driver XenBusDxe
> +#
> +#  TODO: Copyright for UEFI Driver XenBusDxe
> +#
> +#  TODO: License for UEFI Driver XenBusDxe

It looks like this is still todo by the end of the series.

-Jordan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel