Re: [Xen-devel] [PATCH 2/2] libxl: Avoid fd leak of qemu state fd during migration

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-10-17 at 13:38 +0100, Wei Liu wrote:
> On Thu, Oct 16, 2014 at 06:44:13PM +0100, Ian Jackson wrote:
> > In a long-running process (such as virt-manager) this might eventually
> > run the process out of fds.
> > 
> > That qemu argument construction might generate an fd that needs to be
> > fed to qemu is a bit odd, but we just run with it and provide a
> > parameter to the qemu argument construction code for this purpose.
> > 
> > There is no need to use the carefd machinery, because leaking the odd
> > copy of this descriptor into a child unexpectedly forked out of
> > another thread, is fine.  We just don't want to leak it back to the
> > main process.
> > 
> > Reported-by: ustermann.max@xxxxxx
> > Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> 
> The reasoning is sensible and the code looks correct.
> 
> Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Also acked. This is a pretty clear bug fix and therefore I have applied
both without waiting for a release exception.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel